Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOUR-20535 Initial Setup (Laravel + Prometheus Integration) #7772

Merged
merged 6 commits into from
Dec 10, 2024

Conversation

gproly
Copy link
Contributor

@gproly gproly commented Nov 27, 2024

Initial Setup (Laravel + Prometheus Integration)

Related Tickets & Packages

@gproly gproly requested a review from nolanpro November 27, 2024 00:29
@gproly gproly changed the base branch from release-2024-fall to feature/FOUR-20257 November 27, 2024 14:21
Copy link

gitguardian bot commented Dec 6, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14796648 Triggered Generic Password 5a10ad0 metrics/compose.yaml View secret
14796648 Triggered Generic Password 6760384 metrics/compose.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@nolanpro
Copy link
Contributor

Git guardian message dismissed because these credentials are for development only

@nolanpro nolanpro merged commit edb490f into feature/FOUR-20257 Dec 10, 2024
8 checks passed
@nolanpro nolanpro deleted the feature/FOUR-20535 branch December 10, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants